Display ICS preview using an ICS library #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks nice! |
PhieF
force-pushed
the
dev/new-view-ics-plugin
branch
from
6e7d024
to
e354fcb
Compare
|
@the-djmaze thanks for the review, all done ! |
|
Thanks! Since there are 3 ICS parsers now (yours, mine and Nextcloud extension). I will update your plugin when available 😉 |
the-djmaze
pushed a commit
that referenced
this pull request
Sep 17, 2024
the-djmaze
pushed a commit
that referenced
this pull request
Sep 17, 2024
|
perfect, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Current implementation of the ICS plugin is a bit messy, as you can see in this screenshot
So we've re-implemented it using this library
https://github.com/kewisch/ical.js
and here is the result with the same file
What would you think of that ?
Thanks !